Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add poetry-core build system for procrastinate #1318

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Add poetry-core build system for procrastinate #1318

merged 1 commit into from
Sep 22, 2023

Conversation

apeschar
Copy link
Contributor

No description provided.

l0b0
l0b0 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you also be willing to create tests for this package? If so, see

  • tests/default.nix for the test entry and
  • the tests/mutmut directory for a module test or tests/matplotlib-post-3-7 for a library test.

@apeschar
Copy link
Contributor Author

I've added tests. :)

@apeschar apeschar requested a review from l0b0 September 21, 2023 13:16
@l0b0
Copy link
Contributor

l0b0 commented Sep 21, 2023

I've added tests. :)

Cool, thank you! Once nixpkgs-fmt is happy I'll approve it.

@apeschar apeschar force-pushed the procrastinate-build-system branch from 7fd1fc8 to 36d56bb Compare September 22, 2023 09:07
@apeschar
Copy link
Contributor Author

Fixed the formatting.

@cpcloud cpcloud added this pull request to the merge queue Sep 22, 2023
Merged via the queue into nix-community:master with commit 100a361 Sep 22, 2023
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

@l0b0 l0b0 Awaiting requested review from l0b0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeschar @l0b0 @cpcloud